Check attribute filter deep equals #2246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YvonneCeelie
added
Type: Bug
added 3 commits
June 7, 2022 16:46
smcvb
requested changes
Jun 8, 2022
There was a problem hiding this comment.
Although this works, we can pull this a little broader by validating if the configured filter in the DeepEqualsMatcher is of type AllFieldsFilter. If this is the case, we can assume that (1) the user doesn't care because they set the filter to AllFieldsFilter or (2) they haven't adjusted the filter and use the default.
test/src/main/java/org/axonframework/test/matchers/DeepEqualsMatcher.java
Outdated
Show resolved
Hide resolved
By checking whether the AllFieldsFilter is used, we can deduce if somebody wants to filter the contents of the event. If this is the case, we shouldn't go down the top-level equals path, but down the reflective equals path. #2246
smcvb
approved these changes
Jun 8, 2022
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 4.5.10 when I register a field to be ignored in a fixture test, the field is not ignored. In the DeepEqualsMatcher a check is missing when before calling the equals method of the object.