Fix duplicate command handler resolver not being used for annotated aggregates #2207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodeDrivenMitch
added
Type: Bug
CodeDrivenMitch
requested review from
gklijs,
smcvb,
m1l4n54v1c and
YvonneCeelie
CodeDrivenMitch
force-pushed
the
1756-no-errorwarning-for-duplicate-commandhandler
branch
from
446834a
to
4b8f007
Compare
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
reviewed
Apr 28, 2022
| verify(commandBus).subscribe(eq(UpdateCommandWithAnnotatedMethod.class.getName()), | ||
| // Is subscribed two times because of the duplicate handler. This is good and indicates usage of the | ||
| // DuplicateCommandHandlerResolver | ||
| verify(commandBus, times(2)).subscribe(eq(UpdateCommandWithAnnotatedMethod.class.getName()), |
There was a problem hiding this comment.
This test should be obsolete with the change in the AnnotatedHandlerInspector, right?
There was a problem hiding this comment.
What do you mean by obsolete? the times(2) change is valid, see the comment. I have added an additional handler, with a different signature. The change in AnnotatedHandlerInspector is to prevent abstract methods from being registered twice (for the same implementation)
There was a problem hiding this comment.
Aaah thanks for clarifying, I wasn't thinking straight enough when I wrote that I guess 😅
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the AggregateAnnotationCommandHandler subscribes to the commandBus, it does so once for every payload type. This is independent of how many handlers are present for that type, since it does so using a set. In addition, it passes itself as the handler, making the DuplicateCommandHandlerResolver useless since comparing handlers is impossible (both handler arguments are the AggregateAnnotationCommandHandler itself, instead of the conflicting handlers).
In this PR this has been changed so the AggregateAnnotationCommandHandler subscribes the child command handlers to the CommandBus, instead of itself. This bypasses its handle and canHandle methods (since it is never really subscribed), but then uses these of the handlers in its list.
In addition, this PR solves an issue with the
AnnotatedHandlerInspector. Even when methods were abstract in a superclass, they were considered a member. This leads to double registrations on the command bus.Closes #1756