Use equals() first for aggregate state check #2196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids performing reflection on classes that may not be declared open to the module that contains the fixtures. Typically, these classes would implement a suitable equals method. This change will test equality using equals first, before attempting to check fields. If equals returns false, it will still check whether an equals method is explicitly implemented. Only when that is not the case, a field-to-field comparison is performed using the same approach for each individual field.
abuijze
added
Type: Enhancement
Instead of explicitlyUnequal(), check for null and whether either class has an equals method through or operations. As this is proceeded by Objects#equals, the scenario of (1) either being null or (2) either not having equals implemented points out equals failed and thus the state check should fail. Next to this, adjust indentation for clarity. #2196
Instead of explicitlyUnequal(), check for null and whether either class has an equals method through or operations. As this is proceeded by Objects#equals, the scenario of (1) either being null or (2) either not having equals implemented points out equals failed and thus the state check should fail. Next to this, adjust indentation for clarity. #2196
smcvb
added
the
Status: In Progress
smcvb
added a commit
that referenced
this pull request
Apr 28, 2022
- Check if expected is null before creating the matcher - Expand description in case matching fails due to accessibility issues - Specify deprecation warning - Change complexity in assertThrows #2196
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids performing reflection on classes that may not be declared
open to the module that contains the fixtures. Typically, these classes
would implement a suitable equals method.
This change will test equality using equals first, before attempting to
check fields. If equals returns false, it will still check whether an
equals method is explicitly implemented. Only when that is not the case,
a field-to-field comparison is performed using the same approach for
each individual field.