Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streaming query #2001

Merged
merged 41 commits into from Mar 24, 2022
Merged

Streaming query #2001

merged 41 commits into from Mar 24, 2022

Conversation

schananas
Copy link
Contributor

Adds support for streaming queries. Streaming query allows client to stream large data result sets.

m1l4n54v1c and others added 11 commits October 21, 2021 10:11
@CLAassistant
Copy link

CLAassistant commented Nov 9, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@schananas schananas marked this pull request as draft November 9, 2021 10:00
@smcvb smcvb added Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: In Progress Use to signal this issue is actively worked on. Type: Feature Use to signal an issue is completely new to the project. labels Nov 12, 2021
@smcvb smcvb added this to the Release 4.6.0 milestone Nov 12, 2021
@m1l4n54v1c
Added JavaDoc to PrioritizedRunnable.
579748b
@m1l4n54v1c
Switched to package private visibility of PrioritizedRunnable.
f7d38b6
@m1l4n54v1c
More JavaDoc and cleanup.
eaf8bfa
@m1l4n54v1c
Merge branch 'master' into streaming-query
8813d91 
# Conflicts:
#	axon-server-connector/src/main/java/org/axonframework/axonserver/connector/query/AxonServerQueryBus.java
#	axon-server-connector/src/test/java/org/axonframework/axonserver/connector/query/AxonServerQueryBusTest.java
#	messaging/src/main/java/org/axonframework/queryhandling/SimpleQueryBus.java
#	messaging/src/test/java/org/axonframework/queryhandling/SimpleQueryBusTest.java
#	pom.xml
@m1l4n54v1c
Fixed versions and merged main branch.
09f97f6
@m1l4n54v1c m1l4n54v1c self-assigned this Feb 22, 2022
@m1l4n54v1c m1l4n54v1c marked this pull request as ready for review February 22, 2022 10:50
smcvb
smcvb requested changes Mar 11, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too many arguments to approve this PR for. Conceptually I'm okay with the intent of the code, by the way. The comments are mainly clean-up and documentation recommendations.

...n/java/org/axonframework/axonserver/connector/query/BlockingQueryResponseProcessingTask.java Outdated Show resolved Hide resolved
...connector/src/main/java/org/axonframework/axonserver/connector/query/AxonServerQueryBus.java Outdated Show resolved Hide resolved
...connector/src/main/java/org/axonframework/axonserver/connector/query/AxonServerQueryBus.java Show resolved Hide resolved
...connector/src/main/java/org/axonframework/axonserver/connector/query/AxonServerQueryBus.java Show resolved Hide resolved
...connector/src/main/java/org/axonframework/axonserver/connector/query/AxonServerQueryBus.java Outdated Show resolved Hide resolved
messaging/src/main/java/org/axonframework/util/ClasspathResolver.java Outdated Show resolved Hide resolved
messaging/src/test/java/org/axonframework/queryhandling/DefaultQueryGatewayTest.java Outdated Show resolved Hide resolved
messaging/src/test/java/org/axonframework/queryhandling/StreamingQueryTest.java Outdated Show resolved Hide resolved
messaging/src/test/java/org/axonframework/queryhandling/StreamingQueryTest.java Outdated Show resolved Hide resolved
messaging/src/test/java/org/axonframework/queryhandling/SimpleQueryBusTest.java Outdated Show resolved Hide resolved
m1l4n54v1c and others added 8 commits March 21, 2022 12:51
@m1l4n54v1c @smcvb
Update axon-server-connector/src/main/java/org/axonframework/axonserv…
b823c06 
…er/connector/query/BlockingQueryResponseProcessingTask.java


JavaDoc fix.

Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@m1l4n54v1c @smcvb
Update axon-server-connector/src/main/java/org/axonframework/axonserv…
b9b25dc 
…er/connector/query/AxonServerQueryBus.java


Error message fix.

Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@m1l4n54v1c @smcvb
Update axon-server-connector/src/main/java/org/axonframework/axonserv…
1f3b320 
…er/connector/query/AxonServerQueryBus.java


Error message fix.

Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@m1l4n54v1c @smcvb
Update axon-server-connector/src/main/java/org/axonframework/axonserv…
c9c17c9 
…er/connector/query/AxonServerQueryBus.java


Error message fix.

Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@m1l4n54v1c @smcvb
Update axon-server-connector/src/main/java/org/axonframework/axonserv…
fd1be4c 
…er/connector/query/PrioritizedRunnable.java


JavaDoc fix.

Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@m1l4n54v1c @smcvb
Update axon-server-connector/src/main/java/org/axonframework/axonserv…
b003ac6 
…er/connector/query/PrioritizedRunnable.java


JavaDoc fix.

Co-authored-by: Steven van Beelen <steven.vanbeelen@axoniq.io>
@m1l4n54v1c
- review comments.
6e6faba
@m1l4n54v1c
Merge remote-tracking branch 'origin/streaming-query' into streaming-…
10685d4 
…query
smcvb
smcvb approved these changes Mar 24, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still a couple of minor JavaDoc comments open. The far majority of my feedback has been processed though. As such, I trust the rest will be dealt with accordingly. Hence, I am approving this pull request.

@m1l4n54v1c m1l4n54v1c merged commit 2c73d33 into master Mar 24, 2022
@m1l4n54v1c m1l4n54v1c deleted the streaming-query branch March 24, 2022 15:23
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Mar 25, 2022
This was referenced Sep 12, 2022
Open
Closed
Closed
@smcvb smcvb mentioned this pull request Sep 27, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m1l4n54v1c m1l4n54v1c m1l4n54v1c left review comments

@smcvb smcvb smcvb approved these changes

@abuijze abuijze Awaiting requested review from abuijze

Assignees

@schananas schananas

@m1l4n54v1c m1l4n54v1c

Labels
Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. Type: Feature Use to signal an issue is completely new to the project.
Projects
None yet
Milestone
Release 4.6.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@schananas @CLAassistant @smcvb @m1l4n54v1c