Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure heartbeat is enabled on all connections #1942

Merged
merged 1 commit into from
Sep 24, 2021
Merged

Ensure heartbeat is enabled on all connections #1942

merged 1 commit into from
Sep 24, 2021

Conversation

abuijze
Copy link
Member

@abuijze abuijze commented Sep 24, 2021

This PR ensures that setting for heartbeat is used to validate all connections to Axon Server, not only the connection used by the main context.

@abuijze abuijze added Type: Enhancement Use to signal an issue enhances an already existing feature of the project. Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. labels Sep 24, 2021
@abuijze abuijze added this to the Release 4.5.4 milestone Sep 24, 2021
@sonarcloud
Copy link

sonarcloud bot commented Sep 24, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.8% 81.8% Coverage
0.0% 0.0% Duplication

smcvb
smcvb approved these changes Sep 24, 2021
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit 78372ed into axon-4.5.x Sep 24, 2021
@smcvb smcvb added the Status: Resolved Use to signal that work on this issue is done. label Sep 24, 2021
@smcvb smcvb deleted the fix-heartbeat-on-all-connections branch September 29, 2021 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@m1l4n54v1c m1l4n54v1c Awaiting requested review from m1l4n54v1c

@saratry saratry Awaiting requested review from saratry

Assignees

@abuijze abuijze

Labels
Priority 2: Should High priority. Ideally, these issues are part of the release they’re assigned to. Status: Resolved Use to signal that work on this issue is done. Type: Enhancement Use to signal an issue enhances an already existing feature of the project.
Projects
None yet
Milestone
Release 4.5.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@abuijze @smcvb