Wrapping call to initial fetchSegments in transaction. #1908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
smcvb
added
Priority 2: Should
smcvb
reviewed
Aug 11, 2021
There was a problem hiding this comment.
Testing this change is gonna be tough... The only thing I can think of right now is spying the TransactionManager and verifying it is used. The problem is that this piece of code is tucked away in a separate thread with its own idea on time... So, would you mind testing this out with the sample project you were talking about that failed due to this missing transaction wrapping?
messaging/src/main/java/org/axonframework/eventhandling/TrackingEventProcessor.java
Outdated
Show resolved
Hide resolved
|
I have tested this locally with the micronaut application I am developing and this resolved the issue |
abuijze
approved these changes
Aug 11, 2021
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.