[#1892] Adjust Upcaster ordering logic in Spring environments #1895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AnnotationAwareOrderComparator does not check for the annotation on bean creation methods, but only on the classes themselves. We can instead use the findAnnotationOnBean(beanName, Order.class) method to get the ordering from any bean creation spot. This allows us to support the @order annotation on @bean annotated methods or fields too. #1892
smcvb
added
Priority 4: Would
smcvb
requested review from
lfgcampos,
m1l4n54v1c,
abuijze,
sandjelkovic and
SaraTorrey
m1l4n54v1c
approved these changes
Jul 21, 2021
|
Kudos, SonarCloud Quality Gate passed! |
smcvb
added
Status: Resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current solution in the
SpringAxonAutoConfigurerwill not check whether a bean creation method has the@Orderannotation.It instead only works if the
@Orderannotation is added to the class of the upcaster itself.Although this works fine, allowing the
@Orderannotation to be paired with the@Beanannotation is friendlier.This pull request adjusts the behavior in the
SpringAxonAutoConfigurersuch that we look for the@Orderannotation through theListableBeanFactory#findAnnotationOnBean(String beanName, Class<A> annotationClass).This method takes bean creation methods into account, hence allowing us to check for the order on those.
With these adjustments, issue #1892 is resolved.