Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Snapshots are not read with snapshot filter and same serializer for events and snapshots #2286

Merged
merged 1 commit into from
Jul 14, 2022
Merged

Snapshots are not read with snapshot filter and same serializer for events and snapshots #2286

merged 1 commit into from
Jul 14, 2022

Conversation

MGathier
Copy link
Member

@MGathier MGathier commented Jul 14, 2022 •
edited by smcvb

Resolves #2285

@MGathier MGathier self-assigned this Jul 14, 2022
@CLAassistant
Copy link

CLAassistant commented Jul 14, 2022 •
edited

CLA assistant check
All committers have signed the CLA.

@MGathier MGathier changed the base branch from master to axon-4.5.x July 14, 2022 07:20
@sonarcloud
Copy link

sonarcloud bot commented Jul 14, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

45.0% 45.0% Coverage
0.0% 0.0% Duplication

@smcvb smcvb added Type: Bug Use to signal issues that describe a bug within the system. Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: In Progress Use to signal this issue is actively worked on. labels Jul 14, 2022
@smcvb smcvb added this to the Release 4.5.14 milestone Jul 14, 2022
smcvb
smcvb approved these changes Jul 14, 2022
View reviewed changes
Copy link
Member

@smcvb smcvb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@smcvb smcvb merged commit f6e33b5 into axon-4.5.x Jul 14, 2022
@smcvb smcvb deleted the fix/2285 branch July 14, 2022 08:04
@smcvb smcvb added Status: Resolved Use to signal that work on this issue is done. and removed Status: In Progress Use to signal this issue is actively worked on. labels Jul 14, 2022
@smcvb smcvb mentioned this pull request Jul 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smcvb smcvb smcvb approved these changes

@gklijs gklijs Awaiting requested review from gklijs

@YvonneCeelie YvonneCeelie Awaiting requested review from YvonneCeelie

Assignees

@MGathier MGathier

Labels
Priority 1: Must Highest priority. A release cannot be made if this issue isn’t resolved. Status: Resolved Use to signal that work on this issue is done. Type: Bug Use to signal issues that describe a bug within the system.
Projects
None yet
Milestone
Release 4.5.14
Development

Successfully merging this pull request may close these issues.

Snapshots are not considered during loading of an Aggregate using Axon-Server-Connector
3 participants
@MGathier @CLAassistant @smcvb