Snapshots are not considered during loading of an Aggregate using Axon-Server-Connector

[zambrovski]

Basic information

• Axon Framework version: 4.5.13
• Axon Server version: 4.5.13-CE (docker)
• JDK version: 11
• Complete executable reproducer if available (e.g. GitHub Repo):

Steps to reproduce

I asked the question in the form here: https://discuss.axoniq.io/t/restoring-es-aggregates-from-aggregatesnapshot/4242

The snapshotter is storing events in Axon Server, but during the load of the aggregate the snapshots are not considered, but the entire event stream is loaded. Switching the event store from Axon Server to for example JPA Event Store fixes the problem. In JPA Event Store the latest snapshot is loaded followed by the sequence of events occurred after the snapshot only.

Expected behaviour

Axon Server Connector uses snapshots to load the state of the aggregate and applies the events occurred after snapshot only.

Actual behaviour

Axon Server Connector is ignoring snapshots to load the state of the aggregate and applies the events from the initial to the latest.

[zambrovski]

As described in the discussion, I believe that this piece of code is not correct:

AxonFramework/axon-server-connector/src/main/java/org/axonframework/axonserver/connector/event/axon/AxonServerEventStore.java

Line 544 in f496fed

} else if (firstSequenceNumber == ALLOW_SNAPSHOTS_MAGIC_VALUE && !snapshotFilterSet) {

It should be rather snapshotFilterSet (which is true by default) and not !snapshotFilterSet.

[MGathier]

The reason for the check is that if there is no snapshot filter, Axon Server will read the snapshot internally and return a stream of events starting with the latest snapshot (if available). However in your case, there is a snapshot filter, and the event store should first read the snapshot from Axon Server, apply the filter and then read the events.

[smcvb]

Closing this issue as it's resolved by pull request #2286.