Fix Sonar issues

- Add private constructor for the utility class HealthStatus - Check for nullability of the connectionStatus boxed boolean #1964
AxonFramework · Mar 9, 2022 · f3a927c · f3a927c
1 parent 1c558ec
commit f3a927c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/spring-boot-autoconfigure/src/main/java/org/axonframework/actuator/HealthStatus.java b/spring-boot-autoconfigure/src/main/java/org/axonframework/actuator/HealthStatus.java
@@ -31,4 +31,8 @@ public abstract class HealthStatus {
      * A {@link Status} suggesting the connection is still working but not at full capacity.
      */
     public static final Status WARN = new Status("WARN");
+
+    private HealthStatus() {
+        // Utility class
+    }
 }
diff --git a/...figure/src/main/java/org/axonframework/actuator/axonserver/AxonServerHealthIndicator.java b/...figure/src/main/java/org/axonframework/actuator/axonserver/AxonServerHealthIndicator.java
@@ -60,13 +60,15 @@ protected void doHealthCheck(Health.Builder builder) {
         Map<String, Boolean> connections = connectionManager.connections();
 
         connections.forEach((context, connectionStatus) -> {
-            if (!connectionStatus) {
+            String contextStatusCode;
+            if (Boolean.FALSE.equals(connectionStatus)) {
+                contextStatusCode = Status.DOWN.getCode();
                 builder.status(HealthStatus.WARN);
             } else {
+                contextStatusCode = Status.UP.getCode();
                 anyConnectionUp.compareAndSet(false, true);
             }
-            builder.withDetail(String.format(CONNECTION, context),
-                               connectionStatus ? Status.UP.getCode() : Status.DOWN.getCode());
+            builder.withDetail(String.format(CONNECTION, context), contextStatusCode);
         });
 
         if (!connections.isEmpty() && !anyConnectionUp.get()) {