Simplify DeadLetterQueueOverflowException throwing

- Only throw DeadLetterQueueOverflowException on enqueue, as enqueueIfPresent already invokes enqueue - Use the sequenceIdentifier constructor for simplicity #2021
AxonFramework · Aug 8, 2022 · 3052d27 · 3052d27
1 parent 5a3f633
commit 3052d27
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 9 deletions.
diff --git a/...rc/main/java/org/axonframework/messaging/deadletter/InMemorySequencedDeadLetterQueue.java b/...rc/main/java/org/axonframework/messaging/deadletter/InMemorySequencedDeadLetterQueue.java
@@ -106,10 +106,7 @@ public static <M extends Message<?>> InMemorySequencedDeadLetterQueue<M> default
     public void enqueue(@Nonnull Object sequenceIdentifier,
                         @Nonnull DeadLetter<? extends M> letter) throws DeadLetterQueueOverflowException {
         if (isFull(sequenceIdentifier)) {
-            throw new DeadLetterQueueOverflowException(
-                    "No room left to enqueue [" + letter.message() + "] for identifier ["
-                            + sequenceIdentifier + "] since the queue is full."
-            );
+            throw new DeadLetterQueueOverflowException(sequenceIdentifier);
         }
 
         if (logger.isDebugEnabled()) {

diff --git a/messaging/src/main/java/org/axonframework/messaging/deadletter/SequencedDeadLetterQueue.java b/messaging/src/main/java/org/axonframework/messaging/deadletter/SequencedDeadLetterQueue.java
@@ -72,11 +72,6 @@ default boolean enqueueIfPresent(@Nonnull Object sequenceIdentifier,
         if (!contains(sequenceIdentifier)) {
             return false;
         }
-
-        if (isFull(sequenceIdentifier)) {
-            throw new DeadLetterQueueOverflowException(sequenceIdentifier);
-        }
-
         enqueue(sequenceIdentifier, letterBuilder.get());
         return true;
     }