Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component prop type validation to use elementType #321

Merged
merged 2 commits into from Oct 15, 2019

Conversation

cheets
Copy link
Contributor

@cheets cheets commented Oct 14, 2019

Fix #320.

@guillaumechervetaxa
Copy link
Contributor

Hi @cheets , I think that @youf-olivier fixed it also in #314

but I do not know why, he do not merge it.

@cheets
Copy link
Contributor Author

cheets commented Oct 14, 2019

Hi, yeah I see he did some changes, the commit name was a bit misleading there so couldn't find it at first. I would still recommend using elementType instead of oneOfType([PropTypes.node, PropTypes.func]) if you take a look behind the reasoning in prop-types repository PR.

Also at least OidcRoutes.js isn't fixed in #314.

@youf-olivier
Copy link
Contributor

I just merged It, but I just wanted to fixed errors for pure Components. Youre solution seems better :)

I Think it's a Good PR, you just have to fix these conflicts.

Copy link
Contributor

@youf-olivier youf-olivier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks !!

@guillaumechervetaxa guillaumechervetaxa merged commit 085665d into AxaFrance:master Oct 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Prop type validation warnings with redirection components
3 participants