Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update splitter for merged s2s data kind #514

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

zhut19
Copy link
Contributor

@zhut19 zhut19 commented Aug 24, 2021

What is the problem / what does the code in this PR do
The gap-size-based merging algorithm we are using now is not able to / optimized for splitting merged multiple scatter S2s, and thus motivates potentially adding the natural break after the merging. This pr is going to update the splitter so that it can also process merged s2s, particularly to circumvent calling sum waveform.

Can you briefly describe how it works?
The first change is to the peak building part that for merged s2s, instead of resetting dt and data with the records, we simply copy the part of data from the pre-split peak and keep the same dt. (One thing to note is that those two fields are only kept within the splitting process, so the split iteration can work. Once outside, those split peaks will be rebuilt from peaklets, so that they have the correct area_per_channel, saturation info, and so on)

The second change is to make it possible to return the peaks in two arrays, one without any splitting and the new peaks from the splitting. This return option is needed, as mentioned above, we need to rebuild the peaks from peaklets but just for those split peaks.

@JoranAngevaare
Copy link
Member

Hi Tianyu, should we keep this PR or can I close it and re-open if it comes up again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants