Update System.Reactive to 4.4.1 to avoid infinite recursive generics in CoreRT #3741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Confirmed resolved with 0.9.999-cibuild0006487-beta. |
grokys
approved these changes
Apr 4, 2020
|
I think this fix should be backport to v0.9 release, otherwise users who are using v0.9.x will never get successful AOT compilation. |
You can just reference ReactiveUI directly from your project. |
|
@kekekeks any reason not to backport this? |
|
Enforcing dependency version that's not strictly required might expose issues in end-user apps for absolutely no reason. AOT was previously broken by us bumping System.Reactive to a newer version for the sake of bumping System.Reactive to a newer version. Also, bumping dependencies is breaking SemVer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the pull request do?
Update System.Reactive to 4.4.1 to avoid infinite recursive generics in CoreRT.
What is the current behavior?
Compilation never finished while building with CoreRT
What is the updated/expected behavior with this PR?
Build with CoreRT successfully.
How was the solution implemented (if it's not obvious)?
This issue was casued by System.Reactive and fixes to System.Reactive has been applied (dotnet/reactive#1116, dotnet/reactive#1121 and dotnet/reactive#1177), so updating System.Reactive can fix this issue.
Checklist
Breaking changes
No
Fixed issues
Fixes #3366