build: update to yarn v3 #538

chrishavekost · 2021-09-18T18:43:00Z

TODOs

Update release workflow (scripts, actions, etc) https://yarnpkg.com/features/release-workflow
- Remove lerna
  - bootstrap support not working, lerna is basically unmaintained now
  - [Question] Yarn 2 was released in Jan. What does it mean for Lerna future? lerna/lerna#2449
  - Lerna is largely unmaintained lerna/lerna#2703
- Investigate changesets for changelog generation, but conventional-changelog may still work fine for us.
- changesetIgnorePatterns config option isn't working
Add workspace constraints
Link workspace dependencies instead of listing package versions https://yarnpkg.com/features/workspaces/
- Before: "@availity/workflow-logger": "^5.5.11"
- After: "@availity/workflow-logger": "workspace:*"

~~- [ ] Enable PnP~~

There is still some work to do if we want to enable PnP in availity-workflow. Running yarn dlx @yarnpkg/doctor detects more than a few places that are likely to cause issues.

…nd TODOs

Adds config changes for monodeploy

chrishavekost · 2021-10-29T03:17:11Z

Pushed out some changes and updated this repo to use monodeploy instead of going with the more manual yarn release workflow. The dry run output from monodeploy looks good to me, so if everyone's okay with these changes we can finally merge this PR 😄

Output from yarn monodeploy --dry-run --config-file monodeploy.config.js --log-level 0

❯ yarn monodeploy --dry-run --config-file monodeploy.config.js --log-level 0
[Exec] git describe --abbrev=0 --match '*@*[[:digit:]]*.[[:digit:]]*.[[:digit:]]*' --exclude '*@*[[:digit:]]*.[[:digit:]]*.[[:digit:]]*-*'
[Exec] git rev-list -1 @availity/workflow-upgrade@5.5.13
➤ YN0000: [Dry Run] [Config] Using:
➤ YN0000: {
  "noRegistry": false,
  "cwd": "/Users/chavekost/Workspaces/availity-workflow",
  "dryRun": true,
  "git": {
    "baseBranch": "2c383a7f1ae34a218b227ba0e99400586d3cfffc",
    "commitSha": "HEAD",
    "remote": "origin",
    "push": true,
    "tag": true
  },
  "conventionalChangelogConfig": "conventional-changelog-conventionalcommits",
  "changelogFilename": "CHANGELOG.md",
  "changesetIgnorePatterns": [
    "**/*.test.js",
    "**/*.spec.{js,ts}",
    "**/*.{md,mdx}",
    "**/yarn.lock"
  ],
  "forceWriteChangeFiles": false,
  "access": "infer",
  "persistVersions": false,
  "autoCommit": false,
  "autoCommitMessage": "chore: release [skip ci]",
  "topological": false,
  "topologicalDev": false,
  "jobs": 0,
  "maxConcurrentReads": 0,
  "maxConcurrentWrites": 0,
  "plugins": [],
  "prerelease": false,
  "prereleaseId": "alpha",
  "prereleaseNPMTag": "canary"
}
➤ YN0000: [Dry Run] [Config] Default Registry Fetch Url: https://registry.npmjs.org
➤ YN0000: [Dry Run] [Exec] git log 2c383a7f1ae34a218b227ba0e99400586d3cfffc..HEAD --format=%H%n%B%n-----------------monodeploy-----------------
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 2192d1dd952b67d76c98b9427d65edfd72929102
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 00767fe90675b43077d0082f4b1d243a684f2468
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 2d5d42c7989c1f224be269f4985fa9c3b1efe211
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root e75c1ba6a32d644cecfc629ebdd043a1255cd15a
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root db9e1a40a6624c7e970497aededf5e6bc3fbd6a5
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root cdc2903e7202b61577c9790d46498995016b950d
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root f6d8d058a58c2b4b382d5dd766dc53da95e2cc1e
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 16eab4d858e3b05e0778d802fcedcaa133a3fbd9
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 5d8c7a11bdadb940aaf359f3ecb9e2424a61fdba
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 6ec74bef368ca762b942214971eabf7d865522ce
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 863f55952a5539d773fc2fd86d801286f1ac4698
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 6633501230c7569049bffe75a2a84dce74fa56eb
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 6bfcedf35e6d7c84671c4764a517feb379414887
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 130c17008035b0a8e7367148f78423639d28d2ea
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root b601f028f2453aadb22f16726a70d0a9590a56cb
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 4dd5c792a68be3081ed072da7877bf7aa5d1ad04
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root fce305e1fa81a050c511395e15b6e0c4491cfec9
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 203e0949191adaecb96094676b4b73a690bb5e29
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 0386a3797c0617f589f2e3ebd7af8045bdfc515c
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 23b17f2231d710201648c293999dc7b77ce17490
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 3b5ee8898379bd657d0b50d0ff89ff236791d6c3
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 248f1e29e70320fc5c9fc04a4037087cb34bba6f
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 40dc5a384a4947252ebdbae066a7ae01a0f6c176
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 719ef9841bf54a05bbeface3f9ad4eb66b2307b3
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root c2d5548061a3edcd048fa6471d220a120cc64489
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root aade6535e9dc0f551a8b95332aab635d0b1e00d7
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 4c22566593eb94a65932d9fcbcba2997f1661d45
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root d01e6ab340b694bef53998a3971a053ef1c5f40e
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 7b02d5dc908e22d53cb38154c189e645ab3b67d1
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root e84c5254b0abaf10d51540a9e4bf3ecf92279943
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 1b01fd1ad9c6c239ed40d58f960a3764198ed74b
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 754a4377c12f178ba3a130994df7aa261059e8b0
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 13b92ccde9376942357224c8c1a86b511871c377
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root fbb1f3cf31878d9cf1035cbe106224d8ed4b494c
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 8f24ed5c55cbc2abc1ff775c51b9bfc3629f592d
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root cf7b8dbb16eb8d8c7387a4b4d37dcceda1ac1c37
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 1e7032a41c889c64931d22b6048146da2027e0f3
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 6a31a228a0a68777a95b8c80718b471cf1f3d68d
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root e9ab6d490bc2ea1e7ae43b14a55be9de1d3eba3f
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root b91cb00fffb38b92fedea788adc29259b090215e
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 863bf547423bca7984f8abf0cc57e80062a19957
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 7366ad4b028332962b8484d79c5ce3d50a2657f8
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 27e446def67624dc799fdbdb4c2495ed4c728ea6
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 4a8cffdfe42041c9d32b335b884c6076c08cf3d3
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 3d09f3c572ad3446b70653d9e75fe0d827dba87f
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 541978c425cc47593edb841809a3bfc87156ee47
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 6235d76d751249e320bd3487ff98855d2466b27f
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 2323084585467566651ced5d96665f9880a27487
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 3504b36b17a41119437c6238780021b775ba903e
➤ YN0000: [Dry Run] [Exec] git diff-tree --no-commit-id --name-only -r --root 58c67124ada2d5bc034f16ee9977fa25b1444255
➤ YN0000: ┌ Fetching Workspace Information
➤ YN0000: └ Completed
➤ YN0000: ┌ Patching Package Manifests
➤ YN0000: │ [Dry Run] [Version Change] @availity/mock-server: 7.0.13 -> 7.0.14 (patch)
➤ YN0000: │ [Dry Run] [Version Change] @availity/workflow: 8.5.0 -> 8.5.1 (patch)
➤ YN0000: │ [Dry Run] [Version Change] @availity/workflow-upgrade: 5.5.13 -> 5.5.14 (patch)
➤ YN0000: └ Completed
➤ YN0000: ┌ Publishing Packages
➤ YN0000: │ [Dry Run] [Publish] @availity/workflow (latest: 8.5.1, https://registry.npmjs.org; undefined)
➤ YN0000: │ [Dry Run] [Publish] @availity/mock-server (latest: 7.0.14, https://registry.npmjs.org; undefined)
➤ YN0000: │ [Dry Run] [Publish] @availity/workflow-upgrade (latest: 5.5.14, https://registry.npmjs.org; undefined)
➤ YN0000: │ [Dry Run] [Publish] '@availity/workflow-upgrade' published.
➤ YN0000: │ [Dry Run] [Publish] '@availity/mock-server' published.
➤ YN0000: │ [Dry Run] [Publish] '@availity/workflow' published.
➤ YN0000: │ [Dry Run] [Tag] @availity/mock-server@7.0.14
➤ YN0000: │ [Dry Run] [Tag] @availity/workflow@8.5.1
➤ YN0000: │ [Dry Run] [Tag] @availity/workflow-upgrade@5.5.14
➤ YN0000: └ Completed
➤ YN0000: ┌ Updating Change Files
➤ YN0000: │ [Dry Run] [Changeset] Data
➤ YN0000: │ {
  "@availity/mock-server": {
    "version": "7.0.14",
    "previousVersion": "7.0.13",
    "changelog": "### [7.0.14](/Robert McGuinness <rob.mcguinness@availity.com>//compare/@availity/mock-server@7.0.13...@availity/mock-server@7.0.14) \"@availity/mock-server\" (2021-10-29)\n\n",
    "tag": "@availity/mock-server@7.0.14",
    "strategy": "patch"
  },
  "@availity/workflow": {
    "version": "8.5.1",
    "previousVersion": "8.5.0",
    "changelog": "### [8.5.1](https://github.com/availity/availity-workflow/compare/@availity/workflow@8.5.0...@availity/workflow@8.5.1) \"@availity/workflow\" (2021-10-29)\n\n",
    "tag": "@availity/workflow@8.5.1",
    "strategy": "patch"
  },
  "@availity/workflow-upgrade": {
    "version": "5.5.14",
    "previousVersion": "5.5.13",
    "changelog": "### [5.5.14](https://github.com/availity/availity-workflow/compare/@availity/workflow-upgrade@5.5.13...@availity/workflow-upgrade@5.5.14) \"@availity/workflow-upgrade\" (2021-10-29)\n\n",
    "tag": "@availity/workflow-upgrade@5.5.14",
    "strategy": "patch"
  }
}
➤ YN0000: │ [Dry Run] [Changelog] Skipping changelog update.
➤ YN0000: │ [Dry Run] [Changelog] Updated /Users/chavekost/Workspaces/availity-workflow/CHANGELOG.md
➤ YN0000: └ Completed
➤ YN0000: ┌ Committing Changes
➤ YN0000: │ [Dry Run] [Publish] Committing changes
➤ YN0000: └ Completed
➤ YN0000: [Dry Run] Monodeploy completed successfully
➤ YN0000: ┌ Cleaning Up
➤ YN0000: └ Completed
➤ YN0000: Done in 2s 476ms

chrishavekost · 2021-10-29T03:21:36Z

packages/workflow/package.json

@@ -106,7 +107,7 @@
    "eslint": "^7.23.0"
  },
  "peerDependencies": {
-    "@availity/mock-server": "^7.0.6",
+    "@availity/mock-server": "*",


This looked wrong, but when I added the workspace protocol back and re-ran yarn, it spit out the same thing again

nylon22

LGTM 🔥

chrishavekost added 8 commits September 18, 2021 12:45

build: update to yarn v3

248f1e2

build: updates lockfile and engines, removes lerna, adds gitignores a…

3b5ee88

…nd TODOs

build: imports interactive-tools plugin

23b17f2

build: imports workspace-tools plugin

0386a37

build: removes nohoist option

203e094

docs: updates min required node version

fce305e

build: changes --frozen-lockfile to --immutable

4dd5c79

build: adds yarnPath local to project

b601f02

chrishavekost requested review from robmcguinness and jordan-a-young September 18, 2021 18:43

chrishavekost added 14 commits September 18, 2021 14:50

build: updates workspace links

130c170

build: run yarn up -R caniuse-lite to update browserslist db

6bfcedf

build(workflow): adds missing babel plugin

6633501

build: uses workspaces foreach to run integration tests

863f559

build: adds changesetIgnorePatterns

6ec74be

build: adds recommended extensions

5d8c7a1

build: adds typescript plugin to yarn

16eab4d

Merge remote-tracking branch 'origin/master' into feat/yarn3

f6d8d05

build: adds monodeploy

cdc2903

build: removes version plugin due to conflict with monodeploy

db9e1a4

Adds config changes for monodeploy

chore: updates contributing guide, adds monodeploy release script

e75c1ba

chore: updates pr template

2d5d42c

chore: adds backup of original changelog

00767fe

refactor: updates changelog path

2192d1d

chrishavekost requested review from danielpickett and nylon22 October 29, 2021 03:17

chrishavekost marked this pull request as ready for review October 29, 2021 03:17

chrishavekost commented Oct 29, 2021

View reviewed changes

chore: removes deprecated option

b23b680

build: removes builds on windows for now

672974d

nylon22 previously approved these changes Oct 29, 2021

View reviewed changes

chore: adds constraints, updates packages, fixes lint errors

dd75dec

chrishavekost dismissed nylon22’s stale review via dd75dec October 29, 2021 14:10

jordan-a-young approved these changes Oct 29, 2021

View reviewed changes

chrishavekost merged commit 6f3e1e1 into master Oct 29, 2021

chrishavekost deleted the feat/yarn3 branch October 29, 2021 15:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: update to yarn v3 #538

build: update to yarn v3 #538

chrishavekost commented Sep 18, 2021 •

edited

chrishavekost commented Oct 29, 2021

chrishavekost Oct 29, 2021

nylon22 left a comment

build: update to yarn v3 #538

build: update to yarn v3 #538

Conversation

chrishavekost commented Sep 18, 2021 • edited

chrishavekost commented Oct 29, 2021

chrishavekost Oct 29, 2021

Choose a reason for hiding this comment

nylon22 left a comment

Choose a reason for hiding this comment

chrishavekost commented Sep 18, 2021 •

edited