Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve how Renovate groups NodeJS PRs #80652

Merged
merged 13 commits into from
Aug 16, 2023
Merged

Conversation

noahtallen
Copy link
Member

@noahtallen noahtallen commented Aug 15, 2023

Proposed Changes

Renovate opens too many PRs for NodeJS. For example:

On top of that, Renovate doesn't update a few other version constants in the repo, like GitHub actions.

To fix:

  • Attempt to group the CircleCi update in with the main Node PR
  • Attempt to exclude one package.json file from node updates, since it should stay low
  • Remove the engines field from the generator package; it isn't needed.
  • Use nvmrc for setup-node in GH actions, since it's supported.
  • Remove some cases where we hardcoded the Node version in readmes; it doesn't seem worth keeping these updates when we can just reference the nvmrc or engines field.
  • Use regex to update one of the Docker images

Testing Instructions

See if Renovate combines these PRs.

@noahtallen noahtallen self-assigned this Aug 15, 2023
@noahtallen noahtallen requested review from worldomonation and a team as code owners August 15, 2023 23:49
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 15, 2023
@noahtallen noahtallen requested a review from a team August 15, 2023 23:50
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@noahtallen
Copy link
Member Author

The changes here are working a lot better -- everything is combined into this PR now: #80658. I think parts aren't quite working (like the one engines field I don't want it to update), but I'll keep looking at that as a follow-up.

@noahtallen noahtallen merged commit 839f74f into trunk Aug 16, 2023
20 of 22 checks passed
@noahtallen noahtallen deleted the improve-node-update-renovate branch August 16, 2023 02:08
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 16, 2023
@noahtallen noahtallen mentioned this pull request Aug 16, 2023
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants