Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update dependency @types/node to ^18.17.3 - autoclosed #80345

Closed
wants to merge 1 commit into from

Conversation

matticbot
Copy link
Contributor

@matticbot matticbot commented Aug 8, 2023

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/node (source) ^18.11.18 -> ^18.17.3 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - "every weekend" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

πŸ”• Ignore: Close this PR and you won't be reminded about these updates again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@matticbot matticbot requested review from a team and worldomonation as code owners August 8, 2023 21:36
@matticbot matticbot added [Type] Task dependencies Pull requests that update a dependency file Framework [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 8, 2023
@matticbot matticbot requested review from a team August 8, 2023 21:36
@dpasque
Copy link
Contributor

dpasque commented Aug 8, 2023

The E2E tests running green means all good from the Kitkat perspective πŸ‘

@matticbot
Copy link
Contributor Author

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@noahtallen
Copy link
Member

noahtallen commented Aug 8, 2023

This PR was me testing Renovate; normally it wouldn't open this PR during the week! I also want to see what NodeJS group settings we might need to adjust. I also want to see how Renovate handles rebases.

@@ -21,7 +21,7 @@
"lib/"
],
"engines": {
"node": ">=14"
"node": ">=v18.17.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We likely want to exclude this

@noahtallen
Copy link
Member

noahtallen commented Aug 9, 2023

I don't think Renovate is behaving as I expected with rebases -- opened a discussion to see it their maintainers have any ideas: renovatebot/renovate#23767. From what I understand, our config settings should have prevented the rebases today.

@matticbot matticbot force-pushed the renovate/node-18.x branch 11 times, most recently from 0baed0f to 475688f Compare August 9, 2023 13:11
@matticbot matticbot changed the title chore(deps): update dependency node to v18.17.0 chore(deps): update dependency node to v18.17.0 - autoclosed Aug 15, 2023
@matticbot matticbot closed this Aug 15, 2023
@matticbot matticbot deleted the renovate/node-18.x branch August 15, 2023 23:53
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 15, 2023
@matticbot matticbot changed the title chore(deps): update dependency node to v18.17.0 - autoclosed chore(deps): update dependency node to v18.17.0 Aug 16, 2023
@matticbot matticbot reopened this Aug 16, 2023
@matticbot matticbot restored the renovate/node-18.x branch August 16, 2023 00:06
@matticbot matticbot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. labels Aug 16, 2023
@matticbot matticbot force-pushed the renovate/node-18.x branch 3 times, most recently from 17f869a to 52fdf59 Compare August 16, 2023 01:24
@matticbot matticbot changed the title chore(deps): update dependency node to v18.17.0 chore(deps): update dependency @types/node to ^18.17.3 Aug 16, 2023
@matticbot matticbot changed the title chore(deps): update dependency @types/node to ^18.17.3 chore(deps): update dependency node to v18.17.0 Aug 16, 2023
@matticbot matticbot changed the title chore(deps): update dependency node to v18.17.0 chore(deps): update dependency @types/node to ^18.17.3 Aug 16, 2023
@matticbot matticbot changed the title chore(deps): update dependency @types/node to ^18.17.3 chore(deps): update dependency @types/node to ^18.17.3 - autoclosed Aug 16, 2023
@matticbot matticbot closed this Aug 16, 2023
@matticbot matticbot deleted the renovate/node-18.x branch August 16, 2023 01:59
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 16, 2023
@matticbot matticbot changed the title chore(deps): update dependency @types/node to ^18.17.3 - autoclosed chore(deps): update dependency @types/node to ^18.17.3 Aug 16, 2023
@matticbot matticbot reopened this Aug 16, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 16, 2023
@matticbot matticbot restored the renovate/node-18.x branch August 16, 2023 02:09
@matticbot matticbot changed the title chore(deps): update dependency @types/node to ^18.17.3 chore(deps): update dependency @types/node to ^18.17.3 - autoclosed Aug 16, 2023
@matticbot matticbot closed this Aug 16, 2023
@matticbot matticbot deleted the renovate/node-18.x branch August 16, 2023 02:14
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Aug 16, 2023
@noahtallen
Copy link
Member

This is now closed in favor of #80658, which groups more things together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file Framework [Type] Task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants