Framework: Remove unused React Babel preset #7373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduth
added
Framework
[Status] Needs Review
|
|
gwwar
added
[Status] Ready to Merge
and removed
[Status] Needs Review
aduth
force-pushed
the
remove/babel-preset-react
branch
from
b01948b
to
3800d28
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #1515
This pull request seeks to remove the
babel-preset-reactdependency, as we do not use the React Babel preset but instead specify the individual modules of that preset we make use of (i.e.babel-plugin-transform-react-jsx,babel-plugin-syntax-jsx). Specifically, we chose to opt in to individual modules so as not to enable Flow type support. It's assumed that the preset was included originally and later replaced, but the dependency was not removed.Testing instructions:
Verify that there are no issues building or running Calypso.
/cc @gwwar
Test live: https://calypso.live/?branch=remove/babel-preset-react