Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update changelog and package file for eslint plugin wpcalypso #72475

Merged
merged 2 commits into from Jan 24, 2023

Conversation

noahtallen
Copy link
Member

@noahtallen noahtallen commented Jan 24, 2023

Proposed Changes

Updates the changelog and package.json file for eslint-plugin-wpcalypso to prepare for a new release. I plan to release tomorrow (hence the date), and it's a major version because it's pretty likely that installing this update will result in more rule violations which need to be fixed.

This update was requested by @anomiex to support Node 18.

These other PRs were merged beforehand to make this possible:

I only set engines to Node 14, because the jsdoc eslint update dropped support for older versions. So this just aligns with that for now.

Testing Instructions

None

@noahtallen noahtallen requested review from a team January 24, 2023 01:32
@noahtallen noahtallen self-assigned this Jan 24, 2023
@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2023
@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! 👍

packages/eslint-plugin-wpcalypso/CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
@noahtallen noahtallen merged commit 3f4b753 into trunk Jan 24, 2023
@noahtallen noahtallen deleted the update-info-for-eslint-plugin-wpcalypso branch January 24, 2023 20:30
@github-actions github-actions bot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants