New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update Storybook bundler to webpack 5 #56305
Conversation
Link to Calypso live: https://calypso.live?image=registry.a8c.com/calypso/app:build-14977 |
Here is how your PR affects size of JS and CSS bundles shipped to the user's browser: Sections (~1437 bytes added 📈 [gzipped])
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to. Async-loaded Components (~1437 bytes added 📈 [gzipped])
React components that are loaded lazily, when a certain part of UI is displayed for the first time. Legend What is parsed and gzip size?Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory. Generated by performance advisor bot at iscalypsofastyet.com. |
eb989c1
to
effd0a7
Compare
@@ -264,21 +264,13 @@ object RunAllUnitTests : BuildType({ | |||
""" | |||
} | |||
bashNodeScript { | |||
name = "Build components storybook" | |||
name = "Run storybook tests" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged the two Storybook jobs into one, and added composite-checkout
.
Also, I dropped NODE_ENV="production"
. It was causing problems, because Storybook sets it to development
internally, and webpack's DefinePlugin
was failing with storybookjs/storybook#14257 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tests well!
Changes proposed in this Pull Request
process
in@automattic/search
storybookTesting instructions
Run these commands and verify the load storybook with stories and there are no warnings in the browser console:
yarn components:storybook:start
yarn search:storybook:start
yarn composite-checkout:storybook:start