-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add env var to skip TSC #49984
Add env var to skip TSC #49984
Conversation
Test live: https://calypso.live/?branch=build/skip-tsc |
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
Does the CI run still fail if there are TypeScript errors in branch in some packages that are 100% typed? |
Good catch @simison ! I've changed the |
Added Luna team as reviewer just for visibility since many 100% typed packages are from them, but feel free not to wait for any reviews. :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀 This is working great for me!
That's my question as well — are we still going to be build errors in case of TypeScript errors? |
Yes, ts errors in |
Changes proposed in this Pull Request
Adds env var to skip
tsc
compilation. Since #47502 we don't need to runtsc
to compile the project, we only run it to provide better TypeScript typings for IDEs.This should shave off ~40s every time we run
yarn install
in CI (pretty much in every build).Update: running
tsc
onyarn postinstall
was doing implicit typechecking, failing the build if the are TS type errors. In order to not lose this capability, I added an explicit typecheck when running unit tests.Testing instructions
trunk
(note thatRun unit tests
will be about the same)