Change all references to master branch to trunk #45234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matticbot
added
the
[Status] Needs Review
|
This PR does not affect the size of JS and CSS bundles shipped to the user's browser. Generated by performance advisor bot at iscalypsofastyet.com. |
scinos
approved these changes
Aug 27, 2020
| @@ -11,8 +11,8 @@ console.log( | |||
|
|
|||
| const currentBranch = execSync( 'git rev-parse --abbrev-ref HEAD' ).toString().trim(); | |||
|
|
|||
| if ( 'master' === currentBranch ) { | |||
| if ( ! readline.keyInYN( "You're about to push !!![ master ]!!!, is that what you intended?" ) ) { | |||
| if ( 'trunk' === currentBranch ) { | |||
There was a problem hiding this comment.
Do you think we need to support trunk and master for a period of time while we wait for everybody to rename their local branches?
There was a problem hiding this comment.
Ah, that's a good idea. That should also be helped by the calypso-doctor check I'm going to add as well.
tyxla
reviewed
Aug 27, 2020
sirreal
added
[Status] Needs Review
sarayourfriend
changed the title
scinos
force-pushed
the
cleanup/change-references-to-master-branch-to-trunk
branch
from
94507e6
to
667418c
Compare
sarayourfriend
changed the title
scinos
deleted the
cleanup/change-references-to-master-branch-to-trunk
branch
matticbot
removed
the
[Status] Needs Review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request
Testing instructions
Related to #43395 and #45230
Do not merge until after we rename the branch