Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove problematic language from Jetpack selector and documentation #44529

Closed

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Jul 29, 2020

Changes proposed in this Pull Request

  • Rename isJetpackUserMaster to isJetpackUserConnectionOwner
  • Update a comment to remove problematic language
  • Fix a linting error

Testing instructions

I'm still unclear on these, trying to get verification of exactly how this is.

  • Using an external site that is connected to Calypso via Jetpack, navigate to the "connection settings" and verify that with the correct user you see that you are either an owner or not the owner of the connection.
  • Ensure unit tests still pass

Part of #43395

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Sections (~1 bytes added 📈 [gzipped])

name      parsed_size           gzip_size
settings        +18 B  (+0.0%)       +1 B  (+0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

Copy link
Collaborator

@wp-desktop wp-desktop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WordPress Desktop CI Failure for job "wp-desktop-source".

@saramarcondes please inspect this job's build steps for breaking changes at this link. For temporal failures, you may try to "Rerun Workflow from Failed".

Please also ensure this branch is rebased off latest Calypso.

@matticbot matticbot added the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 29, 2020
@wp-desktop wp-desktop dismissed their stale review July 29, 2020 15:57

wp-desktop ci passing, closing review

@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Jul 29, 2020
@sarayourfriend
Copy link
Contributor Author

Duplicate of #43788

@sarayourfriend sarayourfriend marked this as a duplicate of #43788 Jul 29, 2020
@sirreal sirreal deleted the update/remove-problematic-language-master branch December 4, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants