Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deps: Update webpack-node-externals to 2.1.0 #44012

Merged
merged 1 commit into from Jul 9, 2020

Conversation

sarayourfriend
Copy link
Contributor

@sarayourfriend sarayourfriend commented Jul 8, 2020

Changes proposed in this Pull Request

  • Update webpack-node-externals and remove one instance of problematic language

Testing instructions

  • Verify the build still includes the @automattic/components package by verifying that places that use the components still work. For example the ImageSelector's button usage.

Part of #43395

Related: liady/webpack-node-externals#75

@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@flootr
Copy link
Contributor

flootr commented Jul 9, 2020

@saramarcondes do you know what's going on with calypso.live? This branch is loading (and working correctly!) for me locally but it doesn't on calypso.live. it's now loading for me

@sarayourfriend sarayourfriend merged commit 60712c7 into master Jul 9, 2020
@sarayourfriend sarayourfriend deleted the update/webpack-node-externals branch July 9, 2020 14:46
@sarayourfriend sarayourfriend mentioned this pull request Jul 13, 2020
21 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants