Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calypso Codemods: Pull in to monorepo #36645

Merged
merged 25 commits into from Nov 14, 2019
Merged

Conversation

sirreal
Copy link
Member

@sirreal sirreal commented Oct 10, 2019

Changes proposed in this Pull Request

  • Adds calypso-codemods to the monorepo

Testing instructions

  • npm ci
  • Try codemods like:
  • ./node_modules/.bin/calypso-codemods react-create-class client/components/
  • npm run test-packages calypso-codemods

@sirreal sirreal added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. Packages labels Oct 10, 2019
@sirreal sirreal requested review from sgomes and a team October 10, 2019 09:11
@sirreal sirreal self-assigned this Oct 10, 2019
@matticbot
Copy link
Contributor

@matticbot
Copy link
Contributor

matticbot commented Oct 10, 2019

This PR does not affect the size of JS and CSS bundles shipped to the user's browser.

Generated by performance advisor bot at iscalypsofastyet.com.

@sirreal sirreal force-pushed the add/monorepo-calypso-codemods branch from c68d574 to 3e29236 Compare October 11, 2019 11:24
@sirreal
Copy link
Member Author

sirreal commented Oct 11, 2019

Rebased and lint-free 🤞

@sirreal sirreal force-pushed the add/monorepo-calypso-codemods branch 2 times, most recently from 03a0503 to 15549c5 Compare October 16, 2019 17:33
@sirreal
Copy link
Member Author

sirreal commented Oct 16, 2019

Rebased and squashed Calypso prep commits.

@sirreal sirreal force-pushed the add/monorepo-calypso-codemods branch 3 times, most recently from 9c7de12 to 3b18d75 Compare October 16, 2019 18:31
@ockham
Copy link
Contributor

ockham commented Nov 13, 2019

Gonna rebase.

@ockham ockham force-pushed the add/monorepo-calypso-codemods branch 2 times, most recently from 7f1742b to 30d5a23 Compare November 13, 2019 12:35
@ockham
Copy link
Contributor

ockham commented Nov 13, 2019

Oops, we renamed npm-shrinkwrap.json to package-lock.json two days ago (#37493). I'll amend the last commit...

@ockham ockham force-pushed the add/monorepo-calypso-codemods branch from 30d5a23 to 6a11121 Compare November 13, 2019 12:42
Copy link
Contributor

@ockham ockham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working well, thanks for bringing this into the fold!

Left a few suggestions which should be near-trivial to apply. Let's merge this soon and retire the separate repo!

@sirreal
Copy link
Member Author

sirreal commented Nov 13, 2019

Thanks for the review! All concerns addressed.

@sirreal sirreal force-pushed the add/monorepo-calypso-codemods branch from f495114 to 07cb947 Compare November 14, 2019 15:52
@sirreal sirreal merged commit 8037766 into master Nov 14, 2019
@sirreal sirreal deleted the add/monorepo-calypso-codemods branch November 14, 2019 19:12
@matticbot matticbot removed [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Status] Ready to Merge labels Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants