Material Design Icons: Move svgstore-cli devDep to root-level package.json

[ockham]

There's currently an issue when trying to run npx lerna run build (which builds apps in the apps/ directory):

> @automattic/material-design-icons@1.0.0 build ~/src/wp-calypso/packages/material-design-icons
> svgstore -o svg-sprite/material-icons.svg -p 'icon-' src/**/*.svg


lerna ERR! npm run build stderr:
sh: 1: svgstore: not found

We've been bitten by this issue in the past. The only fix we could find was to move monorepo packages' devDependencies to the top-level package.json.

Changes proposed in this Pull Request

Material Design Icons: Move svgstore-cli devDep to root-level package.json

Testing instructions

Try

npm run distclean && npm ci
npx lerna run build

both on master and on this branch. It will fail there but will work here.

Follow-up

I plan to add a CircleCI test task to guard against this.

[matticbot]

Test live: https://calypso.live/?branch=fix/lerna-apps-build

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

Webpack Runtime
webpack runtime for loading modules. It is included in the HTML page as an inline script. Is downloaded and parsed every time the app is loaded.

name      parsed_size    gzip_size
manifest         +0 B         -1 B  (-0.0%)

Sections
Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

name              parsed_size    gzip_size
gutenberg-editor         +0 B         +0 B

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[blowery]

cc @griffbrad as we both missed this

[griffbrad]

Thanks @ockham and @simison!

[simison]

#32390 "Add an eslint rule to forbid adding devDependencies in packages" — Any takers? 😁