Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update babel monorepo #31572

Merged
merged 2 commits into from
Mar 22, 2019
Merged

fix(deps): update babel monorepo #31572

merged 2 commits into from
Mar 22, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Mar 19, 2019

This PR contains the following updates:

Package Type Update Change References
@​babel/core dependencies minor 7.3.4 -> 7.4.0 homepage, source
@​babel/plugin-proposal-class-properties dependencies minor 7.3.4 -> 7.4.0 source
@​babel/plugin-transform-runtime dependencies minor 7.3.4 -> 7.4.0 source
@​babel/polyfill dependencies minor 7.2.5 -> 7.4.0 homepage, source
@​babel/preset-env dependencies minor 7.3.4 -> 7.4.2 homepage, source
@​babel/runtime dependencies minor 7.3.4 -> 7.4.2 source

Release Notes

babel/babel

v7.4.0

Compare Source

👓 Spec Compliance
  • babel-parser
  • babel-parser, babel-plugin-transform-typescript
  • babel-plugin-proposal-unicode-property-regex, babel-plugin-transform-dotall-regex, babel-plugin-transform-unicode-regex
  • babel-generator, babel-parser, babel-plugin-transform-flow-strip-types, babel-plugin-transform-modules-systemjs
  • babel-generator, babel-parser, babel-plugin-transform-classes, babel-plugin-transform-flow-comments, babel-plugin-transform-flow-strip-types, babel-plugin-transform-new-target
🚀 New Feature
  • babel-helpers, babel-plugin-proposal-class-properties, babel-plugin-proposal-decorators, babel-plugin-proposal-object-rest-spread, babel-plugin-transform-runtime, babel-plugin-transform-typescript, babel-polyfill, babel-preset-env, babel-register, babel-runtime-corejs2, babel-runtime-corejs3
  • babel-template
  • babel-parser, babel-plugin-proposal-partial-application
  • babel-generator, babel-helper-create-class-features-plugin, babel-helpers, babel-plugin-proposal-private-methods
  • babel-generator, babel-types
  • babel-parser
  • babel-generator, babel-parser, babel-plugin-syntax-partial-application, babel-types
🐛 Bug Fix
  • babel-helper-create-class-features-plugin, babel-helper-replace-supers, babel-plugin-proposal-private-methods
  • babel-parser
  • babel-core, babel-plugin-transform-for-of
  • babel-plugin-transform-typescript
    • #​9693 [plugin-transform-typescript] Fix transpiling of TS abstract classes with decorators (@​agoldis)
  • babel-traverse, babel-types
  • babel-plugin-proposal-object-rest-spread
    • #​9628 [proposal-object-rest-spread] fix templateLiteral in extractNormalizedKeys (@​pnowak)
  • babel-plugin-transform-modules-systemjs
  • babel-generator, babel-parser
  • babel-helper-split-export-declaration, babel-plugin-transform-modules-commonjs, babel-traverse
  • babel-plugin-transform-parameters, babel-plugin-transform-typescript, babel-types
    • #​9605 [plugin-transform-typescript] Strip type imports used in Enums and object types (@​echenley)
  • babel-helper-call-delegate, babel-plugin-transform-parameters
  • babel-plugin-proposal-object-rest-spread, babel-plugin-transform-modules-commonjs, babel-traverse, babel-types
  • babel-preset-env
  • babel-helper-define-map, babel-helper-hoist-variables, babel-parser, babel-plugin-proposal-object-rest-spread, babel-plugin-transform-block-scoping, babel-plugin-transform-destructuring, babel-plugin-transform-modules-systemjs, babel-traverse, babel-types
💅 Polish
🏠 Internal

Renovate configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner March 19, 2019 21:06
@matticbot
Copy link
Contributor

@renovate renovate bot added [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. [Type] Task Framework labels Mar 19, 2019
@renovate renovate bot changed the title fix(deps): update babel monorepo to v7.4.0 fix(deps): update babel monorepo Mar 19, 2019
@renovate renovate bot force-pushed the renovate/babel-monorepo branch from 0f6c97c to 7f8768c Compare March 19, 2019 23:42
@blowery
Copy link
Contributor

blowery commented Mar 20, 2019

We probably need to fold #31567 in here as well.

@blowery
Copy link
Contributor

blowery commented Mar 20, 2019

This is gonna take some work. See babel/babel#7646

useBuilIns: entry with corejs: 3
No longer transforms @babel/polyfill.
Transforms all possible core-js entry points to import of related modules (based on data from core-js-compat).
Since of this, we no longer need shippedProposals / proposals flags with useBuilIns: entry.
Removes regenerator-runtime/runtime import where it's not required.

@jsnajdr
Copy link
Member

jsnajdr commented Mar 20, 2019

No longer transforms @babel/polyfill.

I don't get it. Does that mean that preset-env will no longer generate a set of CoreJS imports based on desired browserslist? Or is there some new way to achieve the same goal?

@blowery
Copy link
Contributor

blowery commented Mar 20, 2019

Found the explanation: https://github.com/zloirock/core-js/blob/master/docs/2019-03-19-core-js-3-babel-and-a-look-into-the-future.md#babelpolyfill

Instead of
import "@babel/polyfill";
you should use those 2 lines:

import "core-js/stable";
import "regenerator-runtime/runtime";

@blowery
Copy link
Contributor

blowery commented Mar 20, 2019

Also part of the release announcement at https://babeljs.io/blog/2019/03/19/7.4.0

@renovate renovate bot force-pushed the renovate/babel-monorepo branch 2 times, most recently from 0439832 to 1db8ffd Compare March 21, 2019 10:42
@jsnajdr
Copy link
Member

jsnajdr commented Mar 21, 2019

@blowery After some research, I think we can land this separately, without upgrade to CoreJS 3. We just need to set a corejs: 2 option for the preset-env plugin. Otherwise we'll get a console warning that version 2 is still the default today, but might change to 3 soon. What do you think?

@blowery
Copy link
Contributor

blowery commented Mar 21, 2019

@jsnajdr that sounds good. Gives us some time to play with core-js@3 and see what wrinkles we can find.

renovate-bot and others added 2 commits March 22, 2019 10:37
Needs to be specified explicitly in the latest Babel.
Also remove the `shippedProposal` flag, as there are currently no proposals shipped
in browsers that wouldn't already be in standard ES2018.
@renovate
Copy link
Contributor Author

renovate bot commented Mar 22, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

@jsnajdr
Copy link
Member

jsnajdr commented Mar 22, 2019

I pushed a config change with explicit corejs: 3 for @babel/preset-env. The output is almost identical to the previous Babel version, with few tiny differences caused by the upgrade.

Triggering e2e tests, approving, and going to merge if the tests succeed.

Copy link
Member

@jsnajdr jsnajdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to 🚢

Copy link
Contributor

@blowery blowery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsnajdr jsnajdr merged commit ebf4978 into master Mar 22, 2019
@jsnajdr jsnajdr deleted the renovate/babel-monorepo branch March 22, 2019 14:51
@matticbot matticbot removed the [Status] Needs Review The PR is ready for review. This also triggers e2e canary tests and wp-desktop tests automatically. label Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants