Polish logic of redirect when click Set Up WooPayments from WC Home #7659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
|
Size Change: 0 B Total Size: 1.44 MB ℹ️ View Unchanged
|
oaratovskyi
commented
Nov 8, 2023
oaratovskyi
changed the title
…ore-polish-current-logic
…ore-polish-current-logic
vladolaru
approved these changes
Nov 8, 2023
There was a problem hiding this comment.
Nice to see this proactivity and push for perfection, @oaratovskyi! 💪
All the testing instructions check out! And the code changes make for more resilient system! 🚢 it!
oaratovskyi
deleted the
tweak/7625-set-up-woopayments-link-from-core-polish-current-logic
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #7625
Follow up of #7652 with intent to improve the solution for more account statuses by making decision based on
details_submittedvalue, see p1699436266692369/1699365759.939169-slack-C03KTTK2YMADescription
Merchants currently observe an issue with Set up WooPayments task: when account completed the KYC / are rejected / pending - have Stripe account connected, the link redirect them to
payments/onboardingwhich results in Not allowed page errorChanges proposed in this Pull Request
I decided that the best experience for merchants will be to get redirected to
payments/overviewpage if the account connected to Stripe in any status. If we try to redirect the merchant topayments/onboardingpage when they have Stripe account connected, they'll face Not allowed page. That's why we should redirect even partially onboarded users (details_submitted = false) to the overview page. They'll be able to proceed from there by hitting Finish Setup buttonImportant
Tests are not added since there is no tests for
maybe_handle_onboardingfunction. Creating tests for it is out of scope for this PR. It'll be done in #7654Testing instructions
Pre-requisites
tweak/7625-set-up-woopayments-link-from-core-polish-current-logicStripe account not connected
Completestatuspayments/overviewpageStripe account connected (pending)
Pendingstatuspayments/overviewpageStripe KYC left early / partially onboarded accounts
payments/overviewpagenpm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge