Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed submodule shared-plugins/jetpack-force-2fa #5582

Merged
merged 1 commit into from
May 14, 2024

Conversation

rebeccahum
Copy link
Contributor

@rebeccahum rebeccahum commented May 14, 2024

Description

This removes the jetpack-force-2fa plugin from shared-plugins folder now that it is built into Jetpack 12.7+: https://github.com/Automattic/jetpack/blob/ad49374b17a8801f0faa493bfd5ee8e79acd5df7/projects/packages/connection/src/sso/class-sso.php#L69-L91

Changelog Description

Removed

  • Remove jetpack-force-2fa plugin from shared-plugins folder, as it is included now in SSO module for Jetpack 12.7+. Use add_filter( 'jetpack_force_2fa', '__return_true' ); to enable.

Pre-review checklist

Please make sure the items below have been covered before requesting a review:

  • This change works and has been tested locally or in Codespaces (or has an appropriate fallback).
  • This change works and has been tested on a sandbox.
  • This change has relevant unit tests (if applicable).
  • This change uses a rollout method to ease with deployment (if applicable - especially for large scale actions that require writes).
  • This change has relevant documentation additions / updates (if applicable).
  • I've created a changelog description that aligns with the provided examples.

Pre-deploy checklist

  • VIP staff: Ensure any alerts added/updated conform to internal standards (see internal documentation).

Steps to Test

@rebeccahum rebeccahum marked this pull request as ready for review May 14, 2024 20:28
@rebeccahum rebeccahum requested a review from a team as a code owner May 14, 2024 20:28
Copy link

sonarcloud bot commented May 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.46%. Comparing base (d122025) to head (64ac689).

Additional details and impacted files
@@              Coverage Diff              @@
##             develop    #5582      +/-   ##
=============================================
+ Coverage      29.44%   29.46%   +0.01%     
  Complexity      4764     4764              
=============================================
  Files            281      281              
  Lines          20551    20538      -13     
=============================================
  Hits            6052     6052              
+ Misses         14499    14486      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WPprodigy WPprodigy merged commit bfbef0f into develop May 14, 2024
39 checks passed
@WPprodigy WPprodigy deleted the rm/shared-plugins-jetpack-2fa branch May 14, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants