Blockbase: refactor footers to patterns #5245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yeah, the site tagline there is fine. |
MaggieCabrera
force-pushed
the
try-refactor-footers
branch
from
8dd3d31
to
0b8c77d
Compare
pbking
force-pushed
the
try-refactor-footers
branch
from
bf8b3c1
to
3705f72
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This is a WIP
This PR repeats the work done for headers in #5238 but for footers. We are removing duplicate code and giving the user options to use all possible footers designed between our themes no matter the theme you installed.
I have a couple of comments I'd like to discuss:
Should we change this text to something generic that works for all themes? Or maybe we should make this be the tagline block instead? @kjellr @beafialho I'd love your input on this
Seedlet blocks footer was very different from the original, I tried to make it closer to what it should be. Also ended up opening WordPress/gutenberg#37586 because it's related, I think it's fine if that doesn't get merged though.
The new pattern on geologist with the small search block block style (I didn't apply it to the theme, just made the screenshot, this pattern is not used in any theme at the moment in this PR, pending discussion):
Related issue(s):
I'm adding the extra pattern from #5025
Closes #5025