Blockbase: Add appearanceTools setting to theme.json #5072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The GB issue just got merged. This LGTM! |
|
Oh awesome, good spot! I'll finish up this PR! |
scruffian
reviewed
Nov 24, 2021
| @@ -339,8 +332,6 @@ | |||
| ] | |||
| }, | |||
| "typography": { | |||
| "customFontSize": true, | |||
There was a problem hiding this comment.
Are you sure we can remove this? I didn't see it mentioned in the GB PR?
There was a problem hiding this comment.
WordPress/gutenberg#36246 yeah I think it is in there
There was a problem hiding this comment.
Oh sorry I was looking at the wrong PR
scruffian
approved these changes
Nov 24, 2021
|
This should be mergeable now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not merge until GB 12.1 is live on wpcom
Changes proposed in this Pull Request:
This PR adds the new
appearanceToolssetting to theme.json, which allows us to remove several other properties in favor of this single property.These changes are based on this Gutenberg PR: WordPress/gutenberg#36646.
Related issue(s):
Closes #5029