Blockbase: search block font size #4865
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Change looks good. I'll leave the design 👍 to others but if it looks good it's good to bring in. Also I see no negatives to bringing this in before the change lands in Gutenberg besides the lineheight difference. |
|
What is the font size that's used for Buttons by default in Blockbase? I think it might make sense to match that. |
ok, then it's even bigger than the original font-size and my change, I'll make the change if you are fine with that: Before:
|
MaggieCabrera
force-pushed
the
blockbase-search-block-font-size
branch
from
573c1c0
to
1b1a13e
Compare
|
Using the same size is great. Thanks, @MaggieCabrera! |
pbking
approved these changes
Oct 21, 2021
pbking
force-pushed
the
blockbase-search-block-font-size
branch
from
1b1a13e
to
c9fa4ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This PR WordPress/gutenberg#35723 is about to be merged and it will affect all Blockbase themes. Previously, applying font-size to the search block via theme.json didn't work, after the GB PR is merged it will start working. Before the PR, the search block on all BB themes was simply applying the browser default rules for inputs (about 13.333px on FF). I decided on using --wp--preset--font-size--small instead, it will make the block look a little bit bigger don't he themes but I think it makes it more consistent with the rest of the elements of the theme than the random browser size.
I'm also changing the line-height so that the difference in size is not as big.
Skatepark
After the related PR is merged, the font size of the block will inherit directly from the body font, which will be much bigger than this.
@kjellr @beafialho @melchoyce I'm tagging you since this will introduce a slight visual change.
Related issue(s):
WordPress/gutenberg#35723