Try: Removing child-theme.json #4807
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
|
not relevant for testing purposes but when this lands and we change all themes, we should add |
|
One thing I noticed tinkering with this is that our build process has a special scenario for the custom templates (where they are merged instead of replaced). The rest of the properties seem to be following standard procedure ok, but in order to keep the custom templates definitions consistent across this change it will need to define all of the templates expected to be available. |
Merged
|
Closing in favour of #4861 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this Pull Request:
This works with WordPress/gutenberg#35459. With that PR checked out, it should no longer be necessary to build the theme.json, Gutenberg will do it for you.
The theme should behave the same as before.