Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding a search icon to the Geologist + Zoologist footers #5025

Closed
kjellr opened this issue Nov 12, 2021 · 1 comment · Fixed by #5245
Closed

Consider adding a search icon to the Geologist + Zoologist footers #5025

kjellr opened this issue Nov 12, 2021 · 1 comment · Fixed by #5245

Comments

@kjellr
Copy link
Contributor

kjellr commented Nov 12, 2021

Let's try adding a search to the footer of Geologist + Zoologist. It should:

  • Use var(--wp--custom--font-sizes--tiny) text (We might need a block style to accomplish this, since we don't want that to apply to all search blocks).
  • Have half of the normal var(--wp--custom--form--padding) around the input field.
  • Be the width of the content column.
  • Only be available on the archive pages, on single post/pages.

I think we should give this a try in a PR and see what we think. To avoid messing with folks' live sites, we may need to implement this in a way that doesn't add it to existing non-FSE sites.

Mockup:

Screen Shot 2021-11-12 at 7 54 33 AM

@MaggieCabrera
Copy link
Contributor

I think we could consider making a block style on Blockbase for a small version of the search block, since we usually have a big one on the search page/404 and having a smaller one on the header/footer is common too.

It's important to consider that the search block font size rules changed recently (they weren't working on theme.json correctly before) and maybe our current rules need a bit of adjusting so this would be a good opportunity to revisit that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants