Fix Appveyor builds #885
Merged
Fix Appveyor builds #885
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #841, the make target to create platform installers (e.g.
make package-win32) was modified thatmake buildisn't any longer part of this routine.This change however was not reflected in the appveyor config and resulted in a "white screen of death" as the binary did not had the web app bundled. Thanks @mirka for pointing out this issue. #869 (comment)
This PR is required to finish testing for #869
How to test
Check the appveyor build here:
https://ci.appveyor.com/project/adlk/simplenote-electron/build/1.0.192/artifacts