Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New grid layout improvements #1760

Merged
merged 8 commits into from
May 16, 2024
Merged

Conversation

SergioEstevao
Copy link
Contributor

Fixes #1689 #1690

This address some UI issue that were found on the new grid layout

  • It increases the size of the unplayed episodes badge
  • It correct the background color of the badge to match the collection background
  • It adds a shadow around the podcast image to create contrast with the background and some depth
Simulator.Screen.Recording.-.iPhone.15.Pro.Max.-.2024-05-15.at.16.03.39.mp4

To test

  • Start the app
  • Go to Podcasts tab
  • Activate the grid layout by tapping on the top right more button and choose a grid layout
  • Activate badges for unplayed episodes
  • Check if all is looking correct
  • Change a different grid layout
  • Check if still shows correctly
  • Change to a different type of badges
  • Check if all looks correct
  • Disable badges
  • Check if it looks correct

Checklist

  • I have considered if this change warrants user-facing release notes and have added them to CHANGELOG.md if necessary.
  • I have considered adding unit tests for my changes.
  • I have updated (or requested that someone edit) the spreadsheet to reflect any new or changed analytics.

@SergioEstevao SergioEstevao added Up Next issues related to the Up Next feature UI Related UI related issues (colors, icons, etc) Podcast grid layout labels May 15, 2024
@SergioEstevao SergioEstevao added this to the 7.64 ❄️ milestone May 15, 2024
@SergioEstevao SergioEstevao requested a review from a team as a code owner May 15, 2024 15:04
@SergioEstevao SergioEstevao requested review from bjtitus and david-gonzalez-a8c and removed request for a team May 15, 2024 15:04
@dangermattic
Copy link
Collaborator

dangermattic commented May 15, 2024

1 Warning
⚠️ This PR is assigned to the milestone 7.64 ❄️. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.

Generated by 🚫 Danger

Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor changes. Things looked good in testing 👍

podcasts/PodcastGridCell.swift Show resolved Hide resolved
podcasts/GridBadgeView.swift Outdated Show resolved Hide resolved
@SergioEstevao
Copy link
Contributor Author

@bjtitus I addressed your review comments and added shadows to the folder cells too.

Copy link
Contributor

@bjtitus bjtitus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: Looks good!

@SergioEstevao SergioEstevao merged commit 2c72fc0 into release/7.64 May 16, 2024
4 checks passed
@SergioEstevao SergioEstevao deleted the new_grid_layout_improvements branch May 16, 2024 18:37
Copy link

sentry-io bot commented May 29, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ EXC_BAD_ACCESS: Exception 1, Code 1, Subcode 264 > KingfisherManager.retrieveImageFromCache View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Podcast grid layout UI Related UI related issues (colors, icons, etc) Up Next issues related to the Up Next feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants