Clarify toBuffer('raw') byte ordering #1421
Merged
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LinusU
approved these changes
May 13, 2019
legraphista
reviewed
May 24, 2019
types/index.d.ts
Outdated
| * Returns the raw ARGB data without encoding in native-endian byte order, | ||
| * top-to-bottom. | ||
| * Returns the raw ARGB data without encoding, top-to-bottom. On big-endian | ||
| * platforms, the data will instead be BGRA. |
There was a problem hiding this comment.
This comment is a bit confusing.
Shouldn't LE be BGRA, and BE be ARGB?
As I read the text, it gives me the impression that it's the other way around
There was a problem hiding this comment.
Good catch! thank you
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1416