Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(documentarray): make sure you can call unshift() after map() #9013

Merged
merged 1 commit into from
May 18, 2020
Merged

fix(documentarray): make sure you can call unshift() after map() #9013

merged 1 commit into from
May 18, 2020

Conversation

philippejer
Copy link
Contributor

Fix #9012

@AbdelrahmanHafez
Copy link
Collaborator

LGTM.
Thanks 👍

vkarpov15
vkarpov15 approved these changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Just making a note to remove this in the 6.0 branch, because this won't be necessary given the changes in #8356 .

@vkarpov15 vkarpov15 merged commit 14bba6f into Automattic:master May 18, 2020
@philippejer philippejer deleted the gh-9012 branch May 20, 2020 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

@AbdelrahmanHafez AbdelrahmanHafez AbdelrahmanHafez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error when calling unshift() after map()
3 participants
@philippejer @AbdelrahmanHafez @vkarpov15