Feature/enhance auto typed virtuals #12702
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- enables virtual types on all model methods
- virtuals themselves do not have virtuals available
|
apologies for the ping, but i updated the branch to fix the failing test. if there's any further feedback i'll get to it right away 🙂 |
vkarpov15
reviewed
Nov 26, 2022
There was a problem hiding this comment.
We've confirmed that the reported issue is a bug, but there are some test failures and some issues with the test. In general, I'd like to avoid changing TypeScript tests to make them pass, because that may be hiding breaking changes.
We'll take a look and see if there's an alternative fix we can come up with.
| if (doc) { | ||
| expectType<string>(doc.domain); | ||
| const json = doc.toJSON(); | ||
| expectType<string>(json.domain); |
There was a problem hiding this comment.
This is incorrect. domain shouldn't be in json unless you have toJSON: { virtuals: true } in your schema or globally.
vkarpov15
added a commit
that referenced
this pull request
Nov 26, 2022
|
Thanks for the response and thanks for the fix, makes sense 🙂 |
vkarpov15
added a commit
that referenced
this pull request
Nov 28, 2022
fix(types): infer virtuals in query results
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Further enhances existing virtual type inference originally from: #11908
Virtual properties are not available on model methods such as
findOne, this PR adds that functionality across all model methods.Also resolves: #12684