Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): make array paths optional in inferred type of array default returns undefined #12649

Merged
merged 2 commits into from Nov 2, 2022
Merged

fix(types): make array paths optional in inferred type of array default returns undefined #12649

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
80f597f
fix(types): make array paths optional in inferred type of array defau…
vkarpov15 Nov 2, 2022
1f6864f
test: address some code review comments to streamline tests
vkarpov15 Nov 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions test/types/schema.test.ts
View file
Open in desktop
Expand Up @@ -412,6 +412,7 @@ export function autoTypedSchema() {
array5: any[];
array6: string[];
array7?: string[];
array8?: string[];
decimal1?: Types.Decimal128;
decimal2?: Types.Decimal128;
decimal3?: Types.Decimal128;
Expand Down Expand Up @@ -458,6 +459,7 @@ export function autoTypedSchema() {
array5: [],
array6: { type: [String] },
array7: { type: [String], default: undefined },
array8: { type: [String], default: () => undefined },
decimal1: Schema.Types.Decimal128,
decimal2: 'Decimal128',
decimal3: 'decimal128'
Expand Down
8 changes: 7 additions & 1 deletion types/inferschematype.d.ts
View file
Open in desktop
Expand Up @@ -60,6 +60,12 @@ declare module 'mongoose' {
: unknown;
}

type IsPathDefaultUndefined<PathType> = PathType extends { default: undefined } ?
true :
PathType extends { default: (...args: any[]) => undefined } ?
true :
false;

/**
* @summary Checks if a document path is required or optional.
* @param {P} P Document path.
Expand All @@ -69,7 +75,7 @@ type IsPathRequired<P, TypeKey extends TypeKeyBaseType = DefaultTypeKey> =
P extends { required: true | [true, string | undefined] } | ArrayConstructor | any[]
? true
: P extends (Record<TypeKey, ArrayConstructor | any[]>)
? P extends { default: undefined }
? IsPathDefaultUndefined<P> extends true
? false
: true
: P extends (Record<TypeKey, any>)
Expand Down