Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed InferSchemaType nullable arrays type inference #12441

Closed
wants to merge 1 commit into from
Closed

Fixed InferSchemaType nullable arrays type inference #12441

wants to merge 1 commit into from

Conversation

lpizzinidev
Copy link
Contributor

fixes #12420

@hasezoey hasezoey added the typescript Types or Types-test related issue / Pull Request label Sep 18, 2022
hasezoey
hasezoey approved these changes Sep 18, 2022
View reviewed changes
Copy link
Collaborator

@hasezoey hasezoey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vkarpov15
vkarpov15 requested changes Sep 26, 2022
View reviewed changes
types/inferschematype.d.ts
@@ -69,7 +69,7 @@ type IsPathRequired<P, TypeKey extends TypeKeyBaseType> =
P extends { required: true | [true, string | undefined] } | ArrayConstructor | any[]
? true
: P extends (Record<TypeKey, ArrayConstructor | any[]>)
? P extends { default: undefined }
? P extends { default: undefined } | { required: false }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comments here: #12420 (comment) . We shouldn't rely on required: false, because required is false by default anyway. We instead need to check if default is a function that returns undefined.

@vkarpov15
Copy link
Collaborator

I'm going to close this since the PR isn't going in the right direction, and now has merge conflicts.

@vkarpov15 vkarpov15 closed this Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 requested changes

@hasezoey hasezoey hasezoey approved these changes

Assignees
No one assigned
Labels
typescript Types or Types-test related issue / Pull Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mongoose.InferSchemaType does not correctly infer nullable arrays
3 participants
@lpizzinidev @vkarpov15 @hasezoey