New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update some tests and config to be more maintainable #12356
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…debugging (to see the actual count instead of "falsy value)
…tead this change is needed, because "start.uri" is now a getter and global variables in mocha get envaluated before a global-setup also change some static connection strings to use "start.uri"
for use in "useDb" instead of combined with just the URI
…e ip:port's for replset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR does:
mocha.opts
tomocha.yml
because mocha stopped supporting the.opts
formatcommon.js
's uris to be consistent across bothuri
anduri2
(before onlyuri
would have the env applied)common.js
to have a extra valuedatabases
so that the databases foruri
anduri2
can also be used for things likeuseDb
instead of just the full uri'scommon.js
'suri
anduri2
common.js
'sdatabases
arraycommon.js
'sdatabases
arraymodel.populate.test.js
to not create connections in the tests themself when not required (and use global instead)model.populate.test.js
to handle cleaningdb2
outside of the tests themselfNote: some changes have been cherry-picked from #12262 to have them already applied (because i dont know how long that PR will be open for) and those changes were unrelated to the point of the mentioned PR
Note for the mocha opts change: i have not re-set the
reporter
to bedot
but insteadspec
because this is way more readable (both in CI and locally)