Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[types] Apply #12125 to Connection #12298

Merged
merged 2 commits into from Aug 21, 2022
Merged

[types] Apply #12125 to Connection #12298

merged 2 commits into from Aug 21, 2022

Conversation

hasezoey
Copy link
Collaborator

Summary

This PR applies the changes from #12125 (and also adapts the tests for connection.model)

vkarpov15
vkarpov15 approved these changes Aug 21, 2022
View reviewed changes
Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 👍 confirmed no impact on perf

@vkarpov15 vkarpov15 added this to the 6.5.3 milestone Aug 21, 2022
@vkarpov15 vkarpov15 merged commit e43eba9 into Automattic:master Aug 21, 2022
@hasezoey hasezoey deleted the apply12125ToConnection branch August 22, 2022 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vkarpov15 vkarpov15 vkarpov15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.5.3
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hasezoey @vkarpov15