Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): pass type to mongodb bulk write operation #12167

Merged
merged 1 commit into from Aug 3, 2022
Merged

fix(types): pass type to mongodb bulk write operation #12167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 27 additions & 0 deletions test/types/models.test.ts
View file
Open in desktop
Expand Up @@ -282,6 +282,33 @@ function bulkWrite() {
M.bulkWrite(ops);
}

function bulkWriteAddToSet() {
const schema = new Schema({
arr: [String]
});

const M = model('Test', schema);

const ops = [
{
updateOne: {
filter: {
arr: {
$nin: ['abc']
}
},
update: {
$addToSet: {
arr: 'abc'
}
}
}
}
];

return M.bulkWrite(ops);
}

export function autoTypedModel() {
const AutoTypedSchema = autoTypedSchema();
const AutoTypedModel = model('AutoTypeModel', AutoTypedSchema);
Expand Down
6 changes: 3 additions & 3 deletions types/models.d.ts
View file
Open in desktop
Expand Up @@ -144,9 +144,9 @@ declare module 'mongoose' {
* if you use `create()`) because with `bulkWrite()` there is only one network
* round trip to the MongoDB server.
*/
bulkWrite(writes: Array<mongodb.AnyBulkWriteOperation>, options: mongodb.BulkWriteOptions & MongooseBulkWriteOptions, callback: Callback<mongodb.BulkWriteResult>): void;
bulkWrite(writes: Array<mongodb.AnyBulkWriteOperation>, callback: Callback<mongodb.BulkWriteResult>): void;
bulkWrite(writes: Array<mongodb.AnyBulkWriteOperation>, options?: mongodb.BulkWriteOptions & MongooseBulkWriteOptions): Promise<mongodb.BulkWriteResult>;
bulkWrite(writes: Array<mongodb.AnyBulkWriteOperation<T>>, options: mongodb.BulkWriteOptions & MongooseBulkWriteOptions, callback: Callback<mongodb.BulkWriteResult>): void;
bulkWrite(writes: Array<mongodb.AnyBulkWriteOperation<T>>, callback: Callback<mongodb.BulkWriteResult>): void;
bulkWrite(writes: Array<mongodb.AnyBulkWriteOperation<T>>, options?: mongodb.BulkWriteOptions & MongooseBulkWriteOptions): Promise<mongodb.BulkWriteResult>;

/**
* Sends multiple `save()` calls in a single `bulkWrite()`. This is faster than
Expand Down