-
-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/ts type improvements #11650
Merged
vkarpov15
merged 13 commits into
Automattic:master
from
taxilian:feature/tsTypeImprovements
Apr 28, 2022
Merged
Feature/ts type improvements #11650
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a4532e7
d.ts: LeanDocument improvement: strip out functions from lean type
taxilian d2f9cc9
d.ts: Minor optimization so that `any` types don't go down a rabbithole
taxilian a16d077
d.ts: Optimize LeanDocument to get source type of Subdocuments if pos…
taxilian bac4a82
d.ts: Optimize LeanArray to infer underlying type when possible
taxilian 659436d
d.ts: Optimize LeanDocument to infer underlying type when possible
taxilian 2210de8
d.ts: Update Query types so helpers are path-aware, rely on FilterQuery
taxilian 2594b79
Clean up toJSON, toObject -- remove redundant methods
taxilian a9792a0
Remove "strip functions" aspect of LeanDocument per PR feedback, will…
taxilian 2423440
Improve LeanDocument type inference to better support union types
taxilian 0ae960b
Fix broken type unit tests
taxilian e099a59
Add a test to ensure that #10293 has not recurred
taxilian e4b007b
Merge branch 'master' into feature/tsTypeImprovements
vkarpov15 9534282
fix typo
vkarpov15 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, I was just reading through the diffs and noticed this minor error.
You changed the name of the function. From
gt
togte
and there is now only one overload for thegt
function.@vkarpov15 @taxilian
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ack! You're right, good catch! @vkarpov15 very sorry about that! I'm assuming you'll want to just fix it since it's merged already? Let me know if you need me for anything
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
covered by #11760