Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor doc.populate FN type. #11649

Merged
merged 2 commits into from
Apr 22, 2022

Conversation

mohammad0-0ahmad
Copy link
Contributor

Related to : #11598

types/document.d.ts Outdated Show resolved Hide resolved
test/types/document.test.ts Outdated Show resolved Hide resolved
types/document.d.ts Outdated Show resolved Hide resolved
types/document.d.ts Show resolved Hide resolved
@mohammad0-0ahmad
Copy link
Contributor Author

mohammad0-0ahmad commented Apr 21, 2022

@vkarpov15 @Uzlopak
I've noticed that when rebasing this PR on top of master branch, for example, the model lose and doc lose its type & become any when hovering.
Although, all tests are passed.

Untitled

Regression started at this commit: 5194756

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, thanks 👍

@vkarpov15 vkarpov15 added this to the 6.3.2 milestone Apr 22, 2022
@vkarpov15 vkarpov15 merged commit 4ab02f8 into Automattic:master Apr 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Types] populate('path', 'selection', model) syntax not supported in types
3 participants