continueOnError option for eachAsync()
#11601
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gregationCursor `eachAsync()` Fix #6355
Uzlopak
requested changes
Mar 30, 2022
There was a problem hiding this comment.
I didn't tested it but only reading the code I think there is a small bug in there.
The preview in EachAsyncMultiError is only generated in the constructor with the passed Array, but not when we add an Error to the errors Array of the EachAsyncMultiError. So I assume the EachAsyncMultiError will not have the correct Error Message.
I guess we could change the let aggregatedErrors = null to const aggregatedErrors = continueOnError && [] and push Errors directly in there and in the last Moment when we want to pass the Error Object to the callback we construct the actual EachAsyncMultiError-Object.
lib/error/eachAsyncMultiError.js
Outdated
|
|
||
|
|
||
| /** | ||
| * The connection failed to reconnect and will never successfully reconnect to |
Uzlopak
reviewed
Mar 30, 2022
AbdelrahmanHafez
requested changes
Mar 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6355