Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Gh 7971) Can define discriminators in the schema #11600

Merged
merged 9 commits into from
Apr 2, 2022
Merged

(Gh 7971) Can define discriminators in the schema #11600

merged 9 commits into from
Apr 2, 2022

Conversation

IslandRhythms
Copy link
Collaborator

No description provided.

@IslandRhythms IslandRhythms self-assigned this Mar 30, 2022
@IslandRhythms IslandRhythms linked an issue Mar 30, 2022 that may be closed by this pull request
lib/schema.js Outdated Show resolved Hide resolved
lib/schema.js Outdated Show resolved Hide resolved
lib/schema.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@AbdelrahmanHafez AbdelrahmanHafez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@vkarpov15 vkarpov15 changed the base branch from master to 6.3 April 2, 2022 16:24
@vkarpov15 vkarpov15 merged commit 626f61b into 6.3 Apr 2, 2022
@vkarpov15 vkarpov15 deleted the gh-7971 branch April 2, 2022 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Define discriminator at subSchema level direcly in subschema
3 participants