Feature: Infer schema type automatically.

[mohammad0-0ahmad]

Replaced with: #11563

[Uzlopak]

Interesting. But do we really need tsafe? We use tsd and you could use expectError from tsd to check if the type is wrong.

[mohammad0-0ahmad]

Interesting. But do we really need tsafe? We use tsd and you could use expectError from tsd to check if the type is wrong.

I use tsafe to compare two types while expectError can compare one type with another type that is returned of value.

[Uzlopak]

I would actually prefer to use tsd and not introduce another package.

But it is good to see this improvement.

[mohammad0-0ahmad]

I would actually prefer to use tsd and not introduce another package.

But it is good to see this improvement.

I totally agree with you. But I couldn't make this test with tsd.

// test/types/schema.test.ts
assert<Equals<InferSchemaType<typeof AutoTypedSchema>, {
    userName: string;
    description?: string;
    isNotExist: boolean;
  }>>();

If you can fix this with tsd instead, then I will delete tsafe.

Best regards!

[Uzlopak]

How about:

  interface faultyInterface {
    userName: string;
    description?: string;
    doesNotExist: boolean;
  }
  expectError<InferSchemaType<typeof AutoTypedSchema>>(
    {} as faultyInterface
  );
  expectType<InferSchemaType<typeof AutoTypedSchema>>({} as M0_0aAutoTypedSchemaType);

Btw. npm run test-tsd throws errors. I know this is a WIP, but wanted to inform you anyway :).

[mohammad0-0ahmad]

How about:

  interface faultyInterface {
    userName: string;
    description?: string;
    doesNotExist: boolean;
  }
  expectError<InferSchemaType<typeof AutoTypedSchema>>(
    {} as faultyInterface
  );
  expectType<InferSchemaType<typeof AutoTypedSchema>>({} as M0_0aAutoTypedSchemaType);

Btw. npm run test-tsd throws errors. I know this is a WIP, but wanted to inform you anyway :).

That's work now, I will remove tsafe now.
This test worked.

  expectError<faultyInterface>(
    {} as InferSchemaType<typeof AutoTypedSchema>
  );

[Uzlopak]

Nice.

Btw. Your code does have linter errors. To fix them if possible automatically just do:

npm run lint -- --fix

[mohammad0-0ahmad]

Hello Uzlopak !
Would you like to check the result at this phase?
Iv'e fixed type on some functions and models static functions.
I will implement same solution for instance methods.
Do you have some suggestion? or maybe some notes or thoughts u would like to share?

[Uzlopak]

this line is humongous
maybe some newlines would make it a little bit more readable

Suggested change

	export type ObtainSchemaGeneric<TSchema, name extends 'DocType' | 'M' | 'TInstanceMethods' | 'TQueryHelpers' | 'DocDefinition'| 'StaticsMethods'> = TSchema extends Schema<infer DocType, infer M, infer TInstanceMethods, infer TQueryHelpers, infer DocDefinition, infer StaticsMethods> ? {DocType:DocType, M:M, TInstanceMethods:TInstanceMethods, TQueryHelpers:TQueryHelpers, DocDefinition:DocDefinition, StaticsMethods:StaticsMethods}[name] : never;
	export type ObtainSchemaGeneric<TSchema, name extends 'DocType' | 'M' | 'TInstanceMethods' | 'TQueryHelpers' | 'DocDefinition'| 'StaticsMethods'> =
	TSchema extends Schema<infer DocType, infer M, infer TInstanceMethods, infer TQueryHelpers, infer DocDefinition, infer StaticsMethods>
	? {DocType:DocType, M:M, TInstanceMethods:TInstanceMethods, TQueryHelpers:TQueryHelpers, DocDefinition:DocDefinition, StaticsMethods:StaticsMethods}[name]
	: never;

[Uzlopak]

so do we add a new option?
Probably also means that we have to modify the docs too.

@vkarpov15
Is adding statics here ok? Or does it could it break something with loadClass or so?

[Uzlopak]

tbh the typings are not that easy to digest. But I have no overall complaint regarding the changes, which would mean that you would need to refactor everything when you are finished and I would do a review then.

I would prefer to your finished PR and then pull IT and Check the typings

[Uzlopak]

Unfortunately I am currently not in Germany but in Iran and Internet is here horrible. 64 - 128 kby/s with regular disconnects. Took me few hours to download Ubuntu. Also have my wedding on Friday. So I have actually no real testing capability till 4. - 5. April, when I am back in Germany.

There are some merge conflicts. Please solve them, to increase the merging capabilities.

I assume that we will get in the first 1-3 weeks after release of the version containing this we could get some bug reports, like we had with the PipelineStages-PR. So it would be cool if you would check the issues after the release for potential regressions.

[mohammad0-0ahmad]

Unfortunately I am currently not in Germany but in Iran and Internet is here horrible. 64 - 128 kby/s with regular disconnects. Took me few hours to download Ubuntu. Also have my wedding on Friday. So I have actually no real testing capability till 4. - 5. April, when I am back in Germany.

There are some merge conflicts. Please solve them, to increase the merging capabilities.

I assume that we will get in the first 1-3 weeks after release of the version containing this we could get some bug reports, like we had with the PipelineStages-PR. So it would be cool if you would check the issues after the release for potential regressions.

Congratulations, I wish you happy times. No worries, I will solve merge conflicts soon, and I will try to check related issues afterwards.

[mohammad0-0ahmad]

I am closing this PR to replace it with a cleaner one.
Link: #11563