Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typescript no Type Hint for overriding Query. #11475

Merged
merged 1 commit into from
Mar 7, 2022

Conversation

minhthinhls
Copy link
Contributor

#11473

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. The two fields below are mandatory.

If you're making a change to documentation, do not modify a .html file directly. Instead find the corresponding .pug file or test case in the test/docs directory.

Summary

Examples

@AbdelrahmanHafez
Copy link
Collaborator

Hello @minhthinhls
Please refer to this discussion where we discuss why we need any, this change still wouldn't give hints to what fields it can add, it only tells us that the value is a string.

What do you think?

Copy link
Collaborator

@vkarpov15 vkarpov15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on my reading of the code, removing any here should be fine. First arg to populate should either be a string, or PopulateOptions.

@vkarpov15 vkarpov15 added this to the 6.2.5 milestone Mar 7, 2022
@vkarpov15 vkarpov15 merged commit 6a2430d into Automattic:master Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants